-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix form grid layout #34145
[4.0] Fix form grid layout #34145
Conversation
Sorry, no, Horizontal scrolling is not responsive. The line must break, as it does on smaller devices. |
Ok, I'm gonna fix it |
Through few hours of searchin the only one solution that I found is to reduce count of columns, but I'm not sure if it is a good architecture solution (change layout of the whole template in order to make one page look better?)... I would love to see a comment from a more experienced developer than me... |
Should this pull request get a test? |
I have tested this item ✅ successfully on 084a140 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34145. |
Sorry for missing. According to this issue #34450 it's okay to add horizontal scroll. But according to this comment #34145 (comment) it's better to break line. So which is better? |
This is the better solution |
I think the problem is more complex than the fix . ` @include media-breakpoint-up(md) {
} from 4 to 2 columns. But what is width the larger one. This view is broken as well
The leading-Class column is problem because it goes over two grid column. |
I added a PR which I think addresses the same issue as this PR. Please toke a look at my PR an see it id addresses the issue and if it is fixed? #35823. If so, then we can close this PR. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34145. |
Pull Request for Issue #33480 and #34081.
Summary of Changes
Added the logic of addin' horizontal scrollbar to grid form when not havin' enough width for elements
Testing Instructions
Create a menu item of "Category Blog" type and go to the "Blog Layout" tab
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request