Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Hide up/down selector arrows for Hits readonly #34486

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Jun 10, 2021

Pull Request for Issue #30885 (partial fix).

Summary of Changes

Depending on the browser, the up/down arrows for number type may display when the field is readonly.
This is the case with Firefox and Safari on Mac as reported in the issue.

This PR fixes the Hits readonly field by changing its type attribute from number to text.

The ID readonly field will be done in a separate PR.

Testing Instructions

Go to the following to add/edit an item and go to the Publishing tab.

Content > Articles
Content > Categories
Components > Contacts
Components > News Feeds
Components > Tags

Make sure that add/edit can be saved successfully.

Actual result BEFORE applying this Pull Request

hits-arrows

Expected result AFTER applying this Pull Request

hits-no-arrows

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 762faa9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34486.

1 similar comment
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 762faa9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34486.

@RickR2H
Copy link
Member

RickR2H commented Jun 10, 2021

I have tested this item ✅ successfully on 762faa9

Tested all the fields in the description.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34486.

@Quy
Copy link
Contributor Author

Quy commented Jun 10, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34486.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2021
@Quy Quy added this to the Joomla 4.0 milestone Jun 10, 2021
@chmst chmst merged commit c544fee into joomla:4.0-dev Jun 11, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 11, 2021
@chmst
Copy link
Contributor

chmst commented Jun 11, 2021

Thanks!

@PhilETaylor

This comment was marked as abuse.

@Quy Quy deleted the hits-spinner branch June 11, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants