[4.0] Fix sorted by: table caption #34487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on f6f6428 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487. |
|
This changes the direction of the arrow which is a toggle. With this PR, re-ordering is no longer possible. |
|
I have tested this item ✅ successfully on f6f6428 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487. |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487. |
|
I have tested this item 🔴 unsuccessfully on f6f6428 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487. |
|
@brianteeman @chmst @sandramay0905 Please test once more |
|
I have tested this item ✅ successfully on 7648da9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487. |
|
I have tested this item ✅ successfully on 7648da9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34487. |
|
Thanks! |
|
Thanks everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #34476.
Summary of Changes
correct ternary operator in $data->direction
Testing Instructions
Visit the articles page in the backend
Sort the table, for example - by Status ascending
Just look at the table caption in the developer tools or just remove class="visually-hidden" from the code
joomla-cms/administrator/components/com_content/tmpl/articles/default.php
Line 110 in 44934f7
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No