[4.0] Remove arrows/spinners from ID readonly field #34493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
changed the title
|
I have tested this item ✅ successfully on de7bcf1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34493. |
1 similar comment
|
I have tested this item ✅ successfully on de7bcf1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34493. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34493. |
joomla-cms-bot
added
PR-4.0-dev
and removed
RTC
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30885.
Summary of Changes
Depending on the browser, the up/down arrows for number type may display when the field is readonly.
This is the case with Firefox and Safari on Mac as reported in the issue.
This PR only fixes the ID readonly field that are visible by changing its
typeattribute from number to text.Testing Instructions
Go to the following to add/edit an item and see the ID field.
Content > Articles
Content > Categories
Content > Fields
Content > Field Groups
Components > Contacts
Components > News Feeds
Components > Tags
Users > Manage
System > Redirect
Make sure that add/edit can be saved successfully.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request