Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cacerts bundled in Joomla and replace with composer package #34691

Closed
wants to merge 1 commit into from

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jul 2, 2021

Summary of Changes

Replaces the outdated cacerts bundled with Joomla HTTP and FOF Download with the latest versions (from 2015 and 2017 respectively)

Testing Instructions

Ensure that the HTTP Package and Downloads package continue to function and use the updated CA Trust

Documentation Changes Required

None

@HLeithner
Copy link
Member

I would like to move this to 3.9.29 (3.9.28 is ready for building final packages) or better 3.10 you remove the old files which could lead to a failure for 3rd party packages depending on the file location.

Maybe it would be better to maintain the 2 files with a composer post update script till EOL of 3.10.

@Fedik
Copy link
Member

Fedik commented Jul 3, 2021

I think @HLeithner is right,
Will be a bad idea to remove this files while 3.9.x.

But, maybe, can add the bundle in parallel :)

@HLeithner
Copy link
Member

I merged #34693 so 3.9.28 has a up to date version.

@wilsonge
Copy link
Contributor Author

wilsonge commented Jul 3, 2021

Closing as alternate PR was merged - if this is a b/c break then it's useless. We can't use composer hooks to update the files because we don't autoload our code with composer in staging.

@wilsonge wilsonge closed this Jul 3, 2021
@wilsonge wilsonge deleted the composer_ca_bundle branch July 3, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants