[#33687] Fix: Cannot upload file to sub-folder in Media Manager

[zero-24]

Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33687&start=0
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33413&start=0
one more:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=33692

Fix based on (german):
http://www.joomlaportal.de/joomla-3-x-installation/309865-sammelthread-joomla-3-3-0-released-2.html#post1534645
http://www.joomla-bugs.de/forum/index.php?topic=582.0

[wilsonge]

As I can't access the trackers (usual broken stuff) nor read german (should have paid more attention at school) how do I replicate this?

[sovainfo]

See #32032 in the Feature tracker, not broken anymore!
You may blame the J!Tracker Application for transmitting this comment.

[sovainfo]

Just try uploading anything to a folder.

You may blame the J!Tracker Application for transmitting this comment.

[zero-24]

@wilsonge
There are different reports that uploading to a sub folder (e.g. images/sampledata/parks) upload the image to the /images folder.

So you can do the following:

1. login to the backend
2. access the media manager
3. navigate to a sub folder
4. try uploading a image
5. apply patch
6. test again

Thanks.

[sovainfo]

#test Confirm issue and resolution.
Folder is now created at the expected location, image is uploaded to current folder.
You may blame the J!Tracker Application for transmitting this comment.

[sovainfo]

For consistency would suggest '$this->input->post->get(' instead of '$this->input->get->get('
You may blame the J!Tracker Application for transmitting this comment.

[Bakual]

For consistency would suggest '$this->input->post->get(' instead of '$this->input->get->get('

This depends if the folder is given in the URL (GET request) or is coming from the form data (POST) imho. The proposed code looks specifially in the URL while your suggestion would look in the form data.

[sovainfo]

Not my line of expertise. Find it strange, both fields (return-url and folder) are hidden fields, one is taken from post, the other from get. Makes me wonder, especially when something doesn't work as expected.

[ghost]

@test
The patch worksforme. Image is now loaded in selected folder

[peterlose]

Test. The PR fixes the problem!

[Bakual]

@sovainfo has a valid point. There is a hidden folder field in the form, but it's not populated with a value. That's the main reason why the current code fails.
The script gets two inputs, one from GET (with the correct value) and one from POST (with an empty value), and the POST one overrides the one from GET.
While this fix works, I would actually prefer it if the form field would properly updated with the correct value. Or just remove the hidden field if we pass the folder in the request anyway (which I think isn't good).
It takes the value from $this->state->folder, see https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_media/views/media/tmpl/default.php#L64 and it looks like this state isn't properly updated when traversing directories.

There are also other places where this state is used, so I gess we may well have other bugs with that.

[ghost]

The patch for File uploads works indeed. However the issue is also applicable for creating subfolders in the media manager. If you create a subdirectory it is placed in the root (I tested that) and not in the directory where you created the sub. I guess Thomas this is one of those places where it indeed bugs as well with that

[sovainfo]

Weird, as reported, creating subfolders worked in my environment.

[n9iels]

creating sub folders works only fore me when I upload a file. Like I described in the tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33413 at 2014-05-05 23:08:58

[ghost]

Exactly the behavior I also experienced that's why I posted. I think
that is because of the double "get" as described by Thomas
On 5/6/2014 4:22 PM, n9iels wrote:

creating sub folders works only fore me when I upload a file. Like i
described in the tracker item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33413

—
Reply to this email directly or view it on GitHub
#3551 (comment).

[ghost]

Here's another a fix or Re:Later for "If you create a subdirectory it is placed in the root (I tested that) and not in the directory where you created the sub".

1. a CSS class is missing to show the parent folder in grey uneditable INPUT (/administrator/components/com_media/views/media/tmpl/default.php)
2. a JQuery error in /media/media/js/mediamanager.js. value is assigned to the index of an INPUT-element in a collection instead to the INPUT-element (JQuery object) itself.

We've tested all three fixes with J!3.2.4 and 3.3.0

Why ...get->get...? Because "folder=..." is added to the action URL by JavaScript, that's transmitted by GET..

http://www.joomlaportal.de/joomla-3-x-installation/309865-sammelthread-joomla-3-3-0-released-5.html#post1535107

[Bakual]

Why ...get->get...? Because "folder=..." is added to the action URL by JavaScript, that's transmitted by GET..

The thing is that the current JInput->get('folder') would actually work fine if the empty hidden folder field wasn't present in the form. We don't really need JInput->get->get('folder').
There are two ways to properly fix this:

• Remove the hidden folder field.
• Fix the hidden folder field and remove the folder parameter from the URL (as it's not needed anymore).

[sovainfo]

Was able to create subfolders multiple levels deep. Also in other folders. Changed the statement into post and back to original. Made no difference, it kept working!

So, I recreated a j33demo environment. Verified existance of the bug, it exists. Added ->get, could upload image. Could also create subfolder, but only after uploading image.

Didn't test suggestion of ilovo brcause I don't like the folder in the url. Would like to have it in the post!

[ghost]

Thomas,
If what you write is the best option than please implement so we can test this and get over it? I also do not like illovo's suggestion because of the url and I have same experience in testing at present as Sovainfo has so let's follow Thomas suggestion ?

[Bakual]

Please test #3575
Looks like the fix in the forum thread mentioned by @illovo is indeed the correct one.

[Bakual]

Fixed with PR #3575
Thanks all!

[Wequips]

Could anyone explain to me what a patch is. I'm struggling with the same issue as you all do. The Media Manager. The final step is: apply patch. But I don't know how to do that...

[sovainfo]

Sounds like you need to apply #3575 using com_patchtester.

[Wequips]

Thanks for messaging!
And this sounds already difficult for me...

[Bakual]

This issue is resolved. Updating to the lastest version of Joomla should fix this.

If not, please open a new issue so it can get fixed.

[Wequips]

I have this version: Joomla! 3.4.1

Two weeks ago I was able to make a sub-folder, but now I can't anymore...

[wilsonge]

Then you should update to 3.4.3 - which got released yesterday!

[Wequips]

OK, I see. Solved. Thaks a lot!