s/joomla.org/the Joomla! project #35602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging on review thanks @PhilETaylor |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Oct 18, 2021
PR joomla/joomla-cms#35836, PR joomla/joomla-cms#35775, PR joomla/joomla-cms#35774, PR joomla/joomla-cms#35602 (Joomla 3), PR joomla/joomla-cms#35559 (Joomla 3).
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Oct 24, 2021
PR joomla/joomla-cms#35602, PR joomla/joomla-cms#35559, + изменения в Joomla 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
s/joomla.org/the Joomla! project
The intent of the opening sentence is that the Joomla project is not involved with sending the email to you. the Joomla projects own homepage joomla.org is irrelevant here. We are trying to convey that the email is coming from your site and not from the Joomla Project.
The reason the opening sentence should refer to the project and not the projects home page is explained also later on in
I left the bang in
Joomla!as that is what is used elsewhere in the email. Rightly or wrongly. And therefore is out of scope of this PR.Testing Instructions
code review, or if you must install an old version of Joomla and trigger the update notification email
Actual result BEFORE applying this Pull Request
This email IS NOT sent by Joomla.org. It is sent automatically by your own site,Expected result AFTER applying this Pull Request
This email IS NOT sent by the Joomla! project. It is sent automatically by your own site,Documentation Changes Required
none