Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the page cache plugin #36042

Merged
merged 26 commits into from
May 13, 2022
Merged

Refactor the page cache plugin #36042

merged 26 commits into from
May 13, 2022

Commits on Nov 14, 2021

  1. Refactor the page cache plugin

    Nicholas K. Dionysopoulos committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    7fcfd9c View commit details
    Browse the repository at this point in the history
  2. Don't try to fix stupid

    Nicholas K. Dionysopoulos committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    e02d6de View commit details
    Browse the repository at this point in the history
  3. Make the plugin class final

    Nicholas K. Dionysopoulos committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    42946c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Using low priority

    This solves the issue when multiple plugins are being
    executed on these 2 events. If a plugin really needs
    to be executed after the page cache plugin it can still
    use \Joomla\Event\Priority::MIN for its own event handler.
    Nicholas K. Dionysopoulos committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    7c0ee86 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. Inject factories into the plugin

    Nicholas K. Dionysopoulos committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    6eda02a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Refactor the page cache plugin

    Nicholas K. Dionysopoulos authored and Nicholas K. Dionysopoulos committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    444fdb2 View commit details
    Browse the repository at this point in the history
  2. Don't try to fix stupid

    Nicholas K. Dionysopoulos authored and Nicholas K. Dionysopoulos committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    45c617b View commit details
    Browse the repository at this point in the history
  3. Make the plugin class final

    Nicholas K. Dionysopoulos authored and Nicholas K. Dionysopoulos committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    8576947 View commit details
    Browse the repository at this point in the history
  4. Using low priority

    This solves the issue when multiple plugins are being
    executed on these 2 events. If a plugin really needs
    to be executed after the page cache plugin it can still
    use \Joomla\Event\Priority::MIN for its own event handler.
    Nicholas K. Dionysopoulos authored and Nicholas K. Dionysopoulos committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    e53aa91 View commit details
    Browse the repository at this point in the history
  5. Inject factories into the plugin

    Nicholas K. Dionysopoulos authored and Nicholas K. Dionysopoulos committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    b2a50ee View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'nikosdion/feature/cache-plugin-refactor…

    …' into feature/cache-plugin-refactor
    Nicholas K. Dionysopoulos committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    4b6a2bf View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Merge remote-tracking branch 'joomla/4.2-dev' into feature/cache-plug…

    …in-refactor
    Nicholas K. Dionysopoulos committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    86369ce View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. Remove version attribute from the XML manifest

    Nicholas K. Dionysopoulos committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    1fcce43 View commit details
    Browse the repository at this point in the history
  2. Remove useless line

    Nicholas K. Dionysopoulos committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    1b57bc6 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Make protected members private

    I left the $app protected to prevent static code
    analysers from concluding that the property must be
    removed because it's never set. This wrong detection is
    the consequence of the way CMSPlugin detects and sets
    this property through Reflection.
    Nicholas K. Dionysopoulos committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    4217285 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Inject the profiler

    Nicholas K. Dionysopoulos committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    5a6d570 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52e20e3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Merge branch '4.2-dev' into feature/cache-plugin-refactor

    # Conflicts:
    #	plugins/system/cache/cache.php
    Nicholas K. Dionysopoulos committed May 4, 2022
    Configuration menu
    Copy the full SHA
    8504b4e View commit details
    Browse the repository at this point in the history
  2. Fix docblock

    Nicholas K. Dionysopoulos committed May 4, 2022
    Configuration menu
    Copy the full SHA
    dbc7acd View commit details
    Browse the repository at this point in the history
  3. Inject frontend router object

    Nicholas K. Dionysopoulos committed May 4, 2022
    Configuration menu
    Copy the full SHA
    8319325 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Configuration menu
    Copy the full SHA
    3db06ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47831bc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2eec592 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    89af2b8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6b36537 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Configuration menu
    Copy the full SHA
    da17dd2 View commit details
    Browse the repository at this point in the history