[4.0] Obsolete code for RTL #36143
Closed
[4.0] Obsolete code for RTL #36143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the code that was added 7 years ago to handle parentheses in RTL being displayed incorrectly in language names When the code was introduced the LTR text was displayed incorrectly when the document was RTL. Browsers are now better at detection and this code is no longer needed. To test install any RTL language eg Arabic or Persian Farsi and make that the admin language. Then go to the following links administrator/index.php?option=com_languages&view=installed&client=1 administrator/index.php?option=com_languages&view=languages and the admin login form Before this PR it should look like the screenshot below. After the PR it should still look the same. If after applying the PR you see something like `English (en-GB(` please mark this as a failed test and report the exact browser and operating system
|
the drone error is unrelated to this pull request |
|
I have tested this item ✅ successfully on b382a0d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36143. |
|
This does not work on Safari 15.1 (17612.2.9.1.20) MacOS Monterey concerning Installed languages
Concerning the admin menu it is wrong before and after patch.
No problem for admin login |
Merged
|
weird that it works in one place and not the other |
|
Closed as it doesnt work in safari the new internet explorer 6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the code that was added 7 years ago to handle parentheses in RTL being displayed incorrectly in language names
When the code was introduced the LTR text was displayed incorrectly when the document was RTL. Browsers are now better at detection and this code is no longer needed.
To test install any RTL language eg Arabic or Persian Farsi and make that the admin language. Then go to the following links
administrator/index.php?option=com_languages&view=installed&client=1administrator/index.php?option=com_languages&view=languagesBefore this PR it should look like the screenshot below. After the PR it should still look the same.
If after applying the PR you see something like
English (en-GB(please mark this as a failed test and report the exact browser and operating system