Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix Hide Article Options #36168

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue #36121.

Summary of Changes

This simple PR fixes issue #36121.

Testing Instructions

  1. Follow instructions at [4.0] Setting "view article options" to No also hides all custom fields tabs. (Regression) #36121 , confirm the issue
  2. Apply patch, confirm the issue fixed and nothing else is broken.

Actual result BEFORE applying this Pull Request

Not possible to enter data for custom fields on article edit screen when Article Options set to Hide

Expected result AFTER applying this Pull Request

It is still possible to enter data for custom fields on article edit screen when Article Options set to Hide

Documentation Changes Required

None.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 22917c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36168.

@brianteeman
Copy link
Contributor

brianteeman commented Nov 30, 2021

After applying the PR and setting hide article options the field "show associations" from the now removed article options tab is present on every tab

image


image

@joomdonation
Copy link
Contributor Author

Sorry, I did not test on multilingual website. The last commit should solve the issue. Could you please test it again? Thanks !

@ceford
Copy link
Contributor

ceford commented Dec 1, 2021

I have tested this item ✅ successfully on ea1f59a

Seems fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36168.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on ea1f59a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36168.

@chmst
Copy link
Contributor

chmst commented Dec 1, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36168.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 1, 2021
@HLeithner HLeithner merged commit 4583f1d into joomla:4.0-dev Dec 1, 2021
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 1, 2021
@Quy Quy added this to the Joomla 4.0.5 milestone Dec 1, 2021
HLeithner added a commit that referenced this pull request Dec 2, 2021
HLeithner added a commit that referenced this pull request Dec 2, 2021
HLeithner added a commit that referenced this pull request Dec 2, 2021
@Quy Quy removed this from the Joomla 4.0.5 milestone Dec 2, 2021
@joomdonation joomdonation deleted the fix_hide_article_options branch December 10, 2021 15:26
wilsonge pushed a commit that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants