[#33796] TinyMCE clean up on paste

[tQuant]

This PR adds "clean up on paste" option to TinyMCE settings. I think this is very basic and usefull settings.

For example, if you copy just 4 short string from MS Word document (attached to tracker item: http://joomlacode.org/gf/download/trackeritem/33796/159223/List%20for%20example.docx) to TinyMCE, then you will get plenty of garbage code: http://pastebin.com/7S43SQhC

If you apply PR and enable "clean up on paste" option, then when copying the same document to TinyMCE you will get this: http://pastebin.com/cwzE8Tqn

Tracker item

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33796&start=0

[wilsonge]

Do you mean this? This to me reads the text is removed and the tags are kept. I don't think that's what you mean?

[tQuant]

Yes, text not removed. In fact it not jsut remove the styles, it replace some styles with tags and remove unnecessary tags. I'm trying to find the correct description of this function...
In the TinyMCE documentation about this function says simply "clean up", without details.

This description would suit?
"If enabled contents will be automatically cleaned up when you paste using Ctrl+V or similar methods."

[phproberto]

Please review coding styles vs Joomla! Coding Standards .

A space is required after an if statement. Also for var names use camelCase. $clean_up should be $cleanUp and same for the rest of variables.

[tQuant]

A space is required after an if statement

You mean empty line?

'$clean_up' should be '$cleanUp'

I will fix that, but all other variables in this file is in '$clean_up' style

[infograf768]

Not sure about this patch:
Should not the default be to ON
It looks to me that one never wants to get the MSWord html mess, therefore should not it just be added as always true?

[tQuant]

I totally agree with you, I'm just not familiar with the Joomla policy about changing the default behavior. And because in Joomla this feature is not used so far, then to not change habitual behavior, I turned off this option by default.
If you want, I can change it.

[infograf768]

I see now better the issue in your patch:
You added the paste plugin in "Advanced mode" although we never include the plugin there

As we indeed only propose the paste plugin in Extended mode, this change

•               plugins : \"table link image code charmap autolink lists importcss\",
  

•               plugins : \"table link image code charmap autolink lists importcss $cleanUpPlugin\",
  

is useless
as well as the definitions for $cleanUpPlugin as the paste plugin will be loaded by

if (!$paste)
+           {
+               $plugins[] = 'paste';
``
+           }

Also please indeed default option to ON.

[tQuant]

If I remove 'paste' plugin from "Advanced mode", then 'clean up' option will works only in "Extended mode".
So the question is: should it work in Simple and Advanced mode or only in Extended?
If it should work in Simple mode, then should I move option from 'Advanced' tab to main tab?

[dgrammatiko]

Go for Simple and default ON 👍

[infograf768]

As we use Paste only in extended mode, I guess we should implement clean up on paste there only.
This would be the most B/C imho

[ghost]

@tested=OK

[tQuant]

Ok, now 'clean up' option works only in extended mode. So to test it, you need to switch to extended mode.
I hope in newer versions of Joomla! (at least 4.0) we can turn on this option by default for all modes, since B/C there is not so important.

[tQuant]

Incidentally, in the extended mode clean up happens without this PR (perhaps in another way). Therefore, if the use of cleaning up is not planned for the simple and advanced mode, this PR can be closed.

[infograf768]

I suggest we discuss this on list

also, we just merged Tiny 4.0.28 version. Please test again with master

[tQuant]

It seems that parameter 'paste_auto_cleanup_on_paste' not work in Tiny 4.
If 'paste' plugin is loaded then clean up on paste works, otherwise - not.

Changes necessary to add 'clean up' to extended mode only:
https://github.com/tQuant/joomla-cms/compare/cleanUpExtendedMode
To all modes:
https://github.com/tQuant/joomla-cms/compare/cleanUpAllModes

[zero-24]

@tQuant can you update your branche to staging?

[coolcat-creations]

I have tested this item 🔴 unsuccessfully on 9c93fa0

Still stuff added like "" and on...

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3661.}

[brianteeman]

I am closing this as it can not work
The code in this PR simply called a tinymce version 3 plugin
We are using tinymce 4 now and the plugins for tinymce and their syntax is different

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3661.}