New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1][bugfix] Use the one true way to render images: with jLayout #37008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dgrammatiko <d.grammatiko@gmail.com>
I have tested this item ✅ successfully on 749070b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008. |
1 similar comment
I have tested this item ✅ successfully on 749070b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008. |
This was referenced Feb 13, 2022
Is this going to be in the J4.1 release? It's passed checks but doesn't seem to have been merged. |
Thanks! |
I've just come back to this PR because when I checked a custom field of type 'Media' it still does not include the dimensions in the image's attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37006 .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
NO