Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1][bugfix] Use the one true way to render images: with jLayout #37008

Merged
merged 3 commits into from Feb 22, 2022

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Feb 11, 2022

Pull Request for Issue #37006 .

Summary of Changes

  • Change the field template layout to use the existing image JLayout

Testing Instructions

  • Add an image to an article via the Images and Links tab
  • Create a custom field of type Media then add an image via that field to an article
  • Inspect the result on the front end

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

NO

Signed-off-by: dgrammatiko <d.grammatiko@gmail.com>
@chmst
Copy link
Contributor

chmst commented Feb 12, 2022

I have tested this item ✅ successfully on 749070b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Feb 12, 2022

I have tested this item ✅ successfully on 749070b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.1.1 milestone Feb 12, 2022
@Quy
Copy link
Contributor

Quy commented Feb 12, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008.

@Scrabble96
Copy link
Contributor

Is this going to be in the J4.1 release? It's passed checks but doesn't seem to have been merged.

@laoneo laoneo merged commit 8a641e0 into joomla:4.1-dev Feb 22, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2022
@laoneo
Copy link
Member

laoneo commented Feb 22, 2022

Thanks!

@dgrammatiko dgrammatiko deleted the 4.1-dev-bug-media-image branch February 22, 2022 13:18
@laoneo laoneo added this to the Joomla 4.1.1 milestone Feb 22, 2022
@Scrabble96
Copy link
Contributor

I've just come back to this PR because when I checked a custom field of type 'Media' it still does not include the dimensions in the image's attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants