[4.1] Codemirror Full Screen #37129
Merged
[4.1] Codemirror Full Screen #37129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR re-introduces the on screen instruction how to make codemirror full screen. (No idea why it was removed the pr doesnt help) AND fixes the positioning of the editor when full screen so that the first 5 lines are not hidden. As there is a css change you will need to use a pre-build package or `npm run build:css`
joomla-cms-bot
added
Language Change
|
How about float right to be subtle?
|
|
updated as requested |
Quy
reviewed
Feb 25, 2022
plugins/editors/codemirror/layouts/editors/codemirror/element.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Feb 25, 2022
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Quy <quy@fluxbb.org>
|
I have tested this item ✅ successfully on 95fd2bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37129. |
1 similar comment
|
I have tested this item ✅ successfully on 95fd2bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37129. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37129. |
|
Thx |
|
Thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Mar 15, 2022
joomla/joomla-cms#35323 + joomla/joomla-cms#35693 + joomla/joomla-cms#36279 - (у нас не было термина "рендеринг") joomla/joomla-cms#36714 + joomla/joomla-cms#36865 + joomla/joomla-cms#36875 + joomla/joomla-cms#37014 + joomla/joomla-cms#37033 + joomla/joomla-cms#37043 - (только для других языков) joomla/joomla-cms#37049 - (только для en-GB) joomla/joomla-cms#37092 + joomla/joomla-cms#37104 + joomla/joomla-cms#37119 + joomla/joomla-cms#37129 + joomla/joomla-cms#37133 + joomla/joomla-cms#37196 + joomla/joomla-cms#37203 + joomla/joomla-cms#37224 + joomla/joomla-cms#37238 +
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces the on screen instruction how to make codemirror full screen. (No idea why it was removed the pr doesnt help) AND fixes the positioning of the editor when full screen so that the first 5 lines are not hidden.
As there is a css change you will need to use a pre-build package or
npm run build:cssEasiest to test in com_templates as that uses codemirror by default