Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] remove db prefix from action logs #37198

Merged
merged 1 commit into from Mar 5, 2022

Conversation

brianteeman
Copy link
Contributor

When performing a checkin of an article from the article manager then the log says performed a check in to table #__content
When performing a checkin using the global checkin then the log says performed a check in to table jos_content

This pr standardises and remove the jos_ from the action logs

(obviously the jos_ is yur own db prefix)

Pull Request for Issue #36889

before

image

after

image

When performing a checkin of an article from the article manager then the log says `performed a check in to table #__content`
When performing a checkin using the global checkin then the log says` performed a check in to table jos_content`

This pr standardises and remove the jos_ from the action logs

(obviously the jos_ is yur own db prefix)
@Quy
Copy link
Contributor

Quy commented Mar 3, 2022

The database prefix is displayed at Global Check-in.

global-check-in

@brianteeman
Copy link
Contributor Author

And what does that have to do with the objective of this pull request. Nothing.

@sandewt
Copy link
Contributor

sandewt commented Mar 4, 2022

I have tested this item ✅ successfully on 08c6854


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37198.

@alikon
Copy link
Contributor

alikon commented Mar 4, 2022

this pr is for actionlogs only
@Quy yours is from com_checkin

@alikon
Copy link
Contributor

alikon commented Mar 4, 2022

I have tested this item ✅ successfully on 08c6854


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37198.

@alikon
Copy link
Contributor

alikon commented Mar 4, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37198.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 4, 2022
@Quy Quy added the PR-4.1-dev label Mar 4, 2022
@wilsonge wilsonge merged commit ab70aea into joomla:4.1-dev Mar 5, 2022
@wilsonge
Copy link
Contributor

wilsonge commented Mar 5, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 5, 2022
@wilsonge wilsonge added this to the Joomla 4.1.1 milestone Mar 5, 2022
@brianteeman
Copy link
Contributor Author

thx

@brianteeman brianteeman deleted the action_log_prefix branch March 5, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants