Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Name attribute in xml - code style #37387

Merged
merged 3 commits into from Apr 1, 2022
Merged

Conversation

brianteeman
Copy link
Contributor

All the <name> elements in the xml files use lowercase except for these two.

Doesn't break anything having these in a different case but it does look odd when you look at the #__extensions table

Code review should be enough

@Quy
Copy link
Contributor

Quy commented Mar 27, 2022

I have tested this item ✅ successfully on 9ff9d26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37387.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 9ff9d26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37387.

@Quy
Copy link
Contributor

Quy commented Mar 27, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37387.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 27, 2022
@Quy Quy added this to the Joomla 4.1.3 milestone Apr 1, 2022
@Quy Quy merged commit 8138995 into joomla:4.1-dev Apr 1, 2022
@Quy
Copy link
Contributor

Quy commented Apr 1, 2022

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 1, 2022
@brianteeman brianteeman deleted the patch-9 branch April 1, 2022 19:31
obuisard pushed a commit to obuisard/joomla-cms that referenced this pull request Feb 21, 2023
* fix EOF

* fix filter forms

fix default sort
sort order dropdown like table columns
fix sort state ->published

* fix manifest

lowercase name (see. joomla#37387)
indentation (spaces vs. tabs)

* cleanup component provider

component do not use SiteRouter and Category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants