[#32055] Add advanced parameters to module chromes #3760
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Each module has some general parameters in the "Advanced" tab:
This parameters are meant to be supported by the templates module chromes. However most chromes don't support this parameters. The only one which currently supports it is the
html5
chrome. You can test this by setting the "Module Style" tohtml5
.Proposal
This PR adds this parameters to some more chromes where it makes sense.
For Isis and Protostar this is the
well
chrome and for the system chromes it's thexhtml
chrome.With this new parameters, the
xhtml
chrome actually does the exact same thing as thehtml5
one.Testing
After applying the patch, play around with the advanced settings and see if it works.
Also make sure nothing changes in appearance as long as you don't change the module settings.
Tracker
This is an alternative solution for the issue raised with http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=32055