Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Load the extension elements from the model in presets download #37639

Merged
merged 4 commits into from May 5, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 24, 2022

Summary of Changes

The presets download view for the admin items, should load the extension elements from the model.

Testing Instructions

  • Create a new administrator menu with the preset "Components Dashboard"
  • Go to the menu items of this new menu, there should be only one with the name "Components"
  • Click on it a couple of components to hide
    image
  • Save and close the menu item
  • Go mack to the menu manager
  • Click on export presets for the new menu
    image

Actual result BEFORE applying this Pull Request

All Works.

Expected result AFTER applying this Pull Request

All works.

@pe7er
Copy link
Contributor

pe7er commented Apr 26, 2022

I have tested this item ✅ successfully on 490dccf

The "Download as Preset" keeps working okay.
The XML exports of the Menu Item from before & after applying the PR, are identical.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37639.

@toivo
Copy link
Contributor

toivo commented May 3, 2022

I have tested this item ✅ successfully on fc2fe3a

Tested successfully in Joomla 4.2.0-alpha3-dev of 3 May in Wampserver 3.2.8 using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37639.

@Quy
Copy link
Contributor

Quy commented May 4, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37639.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 4, 2022
@roland-d roland-d merged commit 2d44192 into joomla:4.2-dev May 5, 2022
@roland-d roland-d deleted the j4/menu/presets-model branch May 5, 2022 19:12
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 5, 2022
@roland-d
Copy link
Contributor

roland-d commented May 5, 2022

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants