Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Frontend: 'Publishing Options: Hide' show 'Publishing' tab fix #37833

Closed
wants to merge 1 commit into from

Conversation

vorayash
Copy link
Contributor

Pull Request for Issue #37816

Summary of Changes

  1. Added condition in frontend article edit file to show publishing tab only when publishing options enabled

Testing Instructions

Set 'Publishing Options' to hide:
image

Actual result BEFORE applying this Pull Request

Open an article in Frontend, 'Publishing' tab is shown:
image

Expected result AFTER applying this Pull Request

'Publishing' tab is not shown:
image

@chmst
Copy link
Contributor

chmst commented May 20, 2022

Sorry, no this is not correct.

The publishing tab contains much more than ony publish_up / publish-down dates, it contains also category, tabs and others settings.
Do we really want to remove all these settings?
As it is now, it is correct from developers point of view.

From users point of view, the name of the tab "publishing" is misleading

@ghost
Copy link

ghost commented May 20, 2022

I have tested this item ✅ successfully on 927b4c4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37833.

Thanks @vorayash

@chmst
Copy link
Contributor

chmst commented May 20, 2022

I have tested this item 🔴 unsuccessfully on 927b4c4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37833.

@vorayash
Copy link
Contributor Author

Sorry, no this is not correct.

The publishing tab contains much more than ony publish_up / publish-down dates, it contains also category, tabs and others settings. Do we really want to remove all these settings? As it is now, it is correct from developers point of view.

From users point of view, the name of the tab "publishing" is misleading

Got it.

@vorayash vorayash closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants