Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] actionlog plugin prepared statements #37935

Merged
merged 2 commits into from May 31, 2022
Merged

Conversation

alikon
Copy link
Contributor

@alikon alikon commented May 31, 2022

follow up #37788 (review)

Summary of Changes

used prepared statements

Testing Instructions

login with incorret credentials
check the user action log

Actual result BEFORE applying this Pull Request

works as expected

Expected result AFTER applying this Pull Request

works as expected

@toivo
Copy link
Contributor

toivo commented May 31, 2022

I have not tested this item.

Unable to test because the Patch Tester does not find one of the files, plugins/actionlog/Joomla/src/Extension/Joomla.php. Had updated the 4.2.0 test site using the latest available Nightly Build update of 4.2.0-beta1-dev from 30 May. The other two Nightly Builds were updated this morning, 31 May, but 4.2.0 was from yesterday.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37935.

@alikon
Copy link
Contributor Author

alikon commented May 31, 2022

i think you'll find the merged #37788 at the next nightly build

@toivo
Copy link
Contributor

toivo commented May 31, 2022

Thank you, will test this PR tomorrow then


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37935.

@sandewt
Copy link
Contributor

sandewt commented May 31, 2022

I have tested this item ✅ successfully on fa76795

Joomla! 4.2.0-beta1-dev Development


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37935.

@Quy
Copy link
Contributor

Quy commented May 31, 2022

I have tested this item ✅ successfully on fa76795


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37935.

@Quy
Copy link
Contributor

Quy commented May 31, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37935.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 31, 2022
@Quy Quy added this to the Joomla 4.2.0 milestone May 31, 2022
@roland-d roland-d merged commit db2752d into joomla:4.2-dev May 31, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 31, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@alikon alikon deleted the patch-4 branch June 1, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants