[4.2] Cleanup some inline phpcs:ignore #38171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
@nikosdion you might want to have a look here as if I'm not mistaken, then I removed some of your recent cs:ignore statements. |
|
The statements were just there to get the PR checks to pass as I was violating Joomla's code style which did not take several things into account, e.g. the fact that some legacy properties which we still have to use were snake_case instead of camelCase. Since your checks pass here, including the PHPCS ones, there's no problem with me :) |
laoneo
changed the title
|
Thanks |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jul 12, 2022
* Remove some cs ignore blocks * inline * dso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some inline CS ignores which can be removed since the transition to PSR 12 is done.