Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space before pgeclass-sfx #38242

Closed
wants to merge 1 commit into from
Closed

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jul 7, 2022

Pull Request for Issue #38238 .

Summary of Changes

As title says - seems that this was forgotten.

Testing Instructions

Add a page class to menu item for a single article.

class="com-content-article item-page my-class

Actual result BEFORE applying this Pull Request

class="com-content-article item-pagemyclass

Expected result AFTER applying this Pull Request

class="com-content-article item-page myclass

Documentation Changes Required

@brianteeman
Copy link
Contributor

pretty sure that this one was kept for b/c - there will be a discussion on it somewhere in one of the many template repositories

@chmst
Copy link
Contributor Author

chmst commented Jul 7, 2022

We could make it ugly like this class="com-content-article item-pagemyclass myclass
But as it is now, we use this pageclass_sfx in an inconsistent way. I have already made an extra override in a site for that.

@brianteeman your opinion? It is ugly - no matter what we do here ;)

@brianteeman
Copy link
Contributor

The ugly option obviously won't work

@brianteeman
Copy link
Contributor

To be clear I don't have a problem with adding a space. It's just my memory saying it wasn't forgotten and there was a reason.

@Quy
Copy link
Contributor

Quy commented Jul 7, 2022

#37055 (comment)

@chmst
Copy link
Contributor Author

chmst commented Jul 7, 2022

Thank you, @Quy - so we can only use overides here.

@chmst chmst closed this Jul 7, 2022
@brianteeman
Copy link
Contributor

lol - so much for my memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants