[5.2] Redesign carousel implementation to reflect documentation - bug fix #38930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix slide vs. ride attribute in both doc block and code (https://getbootstrap.com/docs/5.2/components/carousel/#options) - Include missing params in doc block - Refactor parameter handling to fix unwanted behavior - Remove parameter cleanup to prevent fallback to default values
joomla-cms-bot
added
NPM Resource Changed
|
This pull request has been automatically rebased to 4.3-dev. |
|
I have tested this item ✅ successfully on 780d3d8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930. |
|
To compile the js: npm run build:js This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930. |
|
Ah - I tested this against 5.0.0-beta2-dev This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930. |
|
@Fedik @dgrammatiko I relabeled this a feature and moved it to 5.1 is this something we want and need? |
|
Looks fine, if it works :) |
|
Ditto |
|
This pull request has been automatically rebased to 5.2-dev. |
HLeithner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes a bug in the Bootstrap Caraousel implementation of Joomla! (PHP and ES/JS) that causes valid parameters to be removed from the JavaScript options object that is fed to the Carousel instance.
Testing Instructions
I do not know if the Patch Tester extension will do the JavaScript re-build / pre-processing for you, and hope you know best what to do in this regard.
Actual result BEFORE applying this Pull Request
All options set to false are filtered out, causing the carousel to fall back to its default values.
Expected result AFTER applying this Pull Request
Params that can have a false value are recognised and work as expected.
Link to documentations
Please select:
Documentation link for docs.joomla.org: https://docs.joomla.org/J4.x:Using_Bootstrap_Components_in_Joomla_4#Carousel (slide vs ride)
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Demo Module
mod_bs_carousel.zip