[4] Start and Finished featured article settings cleared when saving article at frontend

[alikon]

Pull Request for Issue #38961 .

Summary of Changes

Get featured up & down info

Testing Instructions

edit a featured article from frontend

Actual result BEFORE applying this Pull Request

featured up & down data cleaned

Expected result AFTER applying this Pull Request

no more data loss

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[WoodyF4u]

I was the person who started #38961
I have seen that it is closed.
We are asked to test it in this PR.
But is there something to test anywhere? Where can I find it?

[alikon]

as usual
for more info https://docs.joomla.org/Testing_Joomla!_patches/en

[WoodyF4u]

I have tested this item ✅ successfully on b77c583

I have tested the patch on a copy of a live site.
The result of the test was good.
Without a patch there was no field information for the beginning and end of the featured articles.
It works fine with the patch.
Even after saving in the frontend, the data is the same on the frontend and backend.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[WoodyF4u]

Is it possible to see this solutuion in the next Joomla 4 release?
For example in 4.2.5?

[joomdonation]

I think you can improve the current code a a little by doing the same with the code in Article model https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/components/com_content/src/Model/ArticleModel.php#L402-L430

• Move the code inside if ($itemId) block
• Only execute the query to get data for featured article only if ($value->featured), same with https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/components/com_content/src/Model/ArticleModel.php#L409

[Scrabble96]

What happened to this PR? Why did it not appear in 4.2.6? More testing on the front and backend shows that:

1. On front end - i) add start and finish dates for Featured, ii) 'Save' (the dates apparently disappear) then 'Cancel', or add the dates and then 'Save and Close', iii) check in backend: Featured dates are shown;
   However...
2. On front end - i) add start and finish dates for Featuring, ii) 'Save' (the dates apparently disappear), iii) continue editing content, iv) Click 'Save and Close', v) check in backend: Featured dates are lost because they have been cleared earlier in the 'Save' operation.

[alikon]

as usual it needs 2 successfull tests and then it's up mantainers / Release leaders to decide

[joomdonation]

I have tested this item ✅ successfully on d04129d

The PR solves the issue. Further improvement could be made to avoid repeating same code for both frontend and backend, but it could be done in separate PR.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[joomdonation]

@Scrabble96 or @WoodyF4u If you have time, please test this PR so that we can get the issue fixed for next release.

[Scrabble96]

I have tested the patch successfully using the Joomla! Patch Tester component on a development site online. I can't see a way to submit my test results, though.

[joomdonation]

You can go to https://issues.joomla.org/tracker/joomla-cms/38975 , click on Test this button at the top to report test result. See the attached screenshot for more details

[Scrabble96]

I have tested this item ✅ successfully on d04129d

Tested as per my comment 2022/12/29

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[joomdonation]

RTC. Thanks!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[WoodyF4u]

I just tested it successfully as well.
I saw that two successful tests have already been done.
So I can't officially confirm it anymore, but I agree with this patch.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[WoodyF4u]

I just tested it successfully as well.
I saw that two successful tests have already been done.
So I can't officially confirm it anymore, but I agree with this patch.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[brianteeman]

@WoodyF4u you can still record your successful test

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[WoodyF4u]

I have tested this item ✅ successfully on d04129d

My test was succesfull.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[WoodyF4u]

Hi Brian,
Done.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38975.}

[fancyFranci]

Thanks a lot!