[4.3] Workflow Transitions

[brianteeman]

Recently there have been several people posting that they don't understand Workflows. I was reviewing my notes from the Workflows presentation I gave this year at JoomlaDay fr and I realised that we can easily remove one area of confusion.

Summary of Changes

Add a title to the options so that it is clear what they are for. It was confusing before because the displayed value is a stage but the options are a transition.

Bizaarely we must have realised this before because the Action button already adds some clarification by saying "Run Transitions"

NOTE: If you are using the workflow from the sample data the problems this PR fixes are more obvious

Testing Instructions

1. Enable workflows
2. in the article list view click on the stage
3. in the article edit view click on the workflow

Actual result BEFORE applying this Pull Request

In the list view it is not clear that there are two different things in the list - current stage name and transitions

In the article view it says Workflow but it should say Workflow Stage and it is not clear that there are two different things in the list - current stage name and transitions

Expected result AFTER applying this Pull Request

Article List View

Article Edit View

Link to documentations

Please select:

• Documentation link for docs.joomla.org:
  screenshots will need updating

• No documentation changes for manual.joomla.org needed

[viocassel]

I have tested this item ✅ successfully on cf92a8d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.}

[jwaisner]

I have tested this item ✅ successfully on cf92a8d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.}

[jwaisner]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.}

[obuisard]

I did not catch this one in time, but the TransitionField could have been modified to extend GroupediistField rather than ListField, where grouping of options is handled more elegantly and would prevent the hard coding of OPTGROUP

[brianteeman]

Do you want me to look at updating this pr with that?

[obuisard]

Do you want me to look at updating this pr with that?

Actually, that would be great! Your code is perfectly valid, but since the core is the reference in terms of coding and use of the API, I would prefer we use the available tools we have. Thank you, Brian!

[brianteeman]

will do boss

[brianteeman]

Having looked at the code I am going to pass on making the change myself and stick with my pr. Feel free of course to reject it and to submit your own.

[obuisard]

Having looked at the code I am going to pass on making the change myself and stick with my pr. Feel free of course to reject it and to submit your own.

@brianteeman I do not want to close this PR because of the work that you put into it and the user benefits.
However, I still think the TransitionField.php should be updated.
There are 5 lines of code to modify and 2 to remove.
I can modify your file and commit the changes so we can save ourselves some time. Ok with you?

[brianteeman]

I would prefer it if you did it as a pr to my branch

[obuisard]

I would prefer it if you did it as a pr to my branch

Ok, I can do that.

[brianteeman]

This will need you tests

[obuisard]

I have tested this item ✅ successfully on 9cbbc25

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.}

[obuisard]

Jacob @jwaisner, would you mind testing the PR once more as the Transition field has been updated to extend Groupedlist? Thank you very much!

[obuisard]

Vio @viocassel, we need a new test for this updated PR, do you mind re-testing? Thank you!

[viocassel]

I have tested this item ✅ successfully on 9cbbc25

👍

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325.}

[obuisard]

Thank you Brian @brianteeman !

[brianteeman]

thx

[Quy]

@brianteeman Can you please look into this for the frontend? Thanks.