Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Remove IE9 code, don't force download of JSON documents #39397

Merged
merged 2 commits into from Sep 2, 2023

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Dec 12, 2022

Summary of Changes

Removes some IE9 code which is causing modern browsers to render JSON documents as plaintext. Also removes forcing file download, which wasn't working anyway because of the first part of code.

Testing Instructions

Enter a JSON page, e.g. index.php?option=com_ajax&format=json. Confirm that JSON is rendered in the browser.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@SharkyKZ SharkyKZ changed the title [5.0] Remove IE9 code [5.0] Remove IE9 code, don't force download of JSON documents Dec 12, 2022
@laoneo
Copy link
Member

laoneo commented Dec 12, 2022

This surely needs to be documented.

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@toivo
Copy link
Contributor

toivo commented Mar 14, 2023

I have tested this item ✅ successfully on ba431a9

Tested successfully in Joomla 5.0.0-dev of 14 March using PHP 8.1.10.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39397.

@HLeithner HLeithner added Feature b/c break This item changes the behavior in an incompatible why. HEADS UP Removal Removes functionality and removed Feature labels Apr 7, 2023
@Hackwar Hackwar added the Feature label Apr 7, 2023
@wilsonge wilsonge enabled auto-merge (squash) July 18, 2023 13:27
@HLeithner HLeithner merged commit dfae596 into joomla:5.0-dev Sep 2, 2023
@HLeithner
Copy link
Member

thanks

@HLeithner HLeithner added this to the Joomla! 5.0 milestone Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP Feature PR-5.0-dev Removal Removes functionality Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants