[5.0] Smart Search: Preventing stemmer exception #39959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hackwar
changed the title
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30372.
Summary of Changes
The stemmer in Smart Search throws an exception when there is no stemmer for that language. We catch that exception successfully, but when debugging with xdebug, the exception stops execution anyway. This change first checks if the language should be available before calling the stemmer factory.
Testing Instructions
Set the language for an item to *, start a debugging session with xdebug, save the item.
Actual result BEFORE applying this Pull Request
Xdebug stops execution with a NotFoundException exception.
Expected result AFTER applying this Pull Request
Xdebug does not stop.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed