Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken Folder::exists() #40403

Closed
wants to merge 2 commits into from
Closed

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 18, 2023

Followup Pull Request for pr #40239.

Summary of Changes

Fixes the error message undefined method Folder::exist, which comes from #40239.

image

Testing Instructions

Edit a module in the back end.

Actual result BEFORE applying this Pull Request

Error message.

Expected result AFTER applying this Pull Request

Module can be edited.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

This fixes the error in the modules but there are lots of other changes in #40239 that need real testing and not just a sinmple code review by one person - there is a reason that we have the testing procedures that we have. And it always breaks when they are not followed

@drmenzelit
Copy link
Contributor

I have tested this item ✅ successfully on 67676e5

With this patch is possible to edit and add modules again


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40403.

@laoneo
Copy link
Member

laoneo commented Apr 18, 2023

Thank you Hannes. Unfortunately we have here the same issue as in #40131, which was moved to 5.0. I'm closing this one in favor of #40406 which reverts basically the change. As a new Exception is thrown here in a libraries file which is a BC break and should be done in 5.0.

@laoneo laoneo closed this Apr 18, 2023
@Hackwar Hackwar deleted the 4.4-folder-exists branch March 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants