Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0]Remove unused workflow strings #40511

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

Removes strings that have never ever been used and marked as deprecated in #40510

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.0-dev labels Apr 30, 2023
@HLeithner HLeithner added the Removal Removes functionality label May 2, 2023
@wilsonge
Copy link
Contributor

So now 4.4 has been merged into 5.0 there's no net changes from this PR. Presumably you still want to remove the big block of strings at the bottom of the file though?

@brianteeman
Copy link
Contributor Author

should be done now - thanks @wilsonge

@wilsonge wilsonge enabled auto-merge (squash) June 28, 2023 13:57
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla! 5.0 milestone Jun 28, 2023
@heelc29
Copy link
Contributor

heelc29 commented Aug 22, 2023

I have tested this item ✅ successfully on d3995f0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40511.

@Quy
Copy link
Contributor

Quy commented Aug 22, 2023

I have tested this item ✅ successfully on 7519e95


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40511.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.0 milestone Aug 22, 2023
@Quy
Copy link
Contributor

Quy commented Aug 22, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40511.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 22, 2023
@wilsonge wilsonge merged commit c4ce360 into joomla:5.0-dev Aug 22, 2023
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 22, 2023
@wilsonge wilsonge added this to the Joomla! 5.0 milestone Aug 22, 2023
@brianteeman brianteeman deleted the 5workflow branch June 30, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.0-dev Removal Removes functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants