Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Inclusive Naming master (various) #41020

Merged
merged 4 commits into from Jun 25, 2023

Conversation

brianteeman
Copy link
Contributor

We should be using inclusive naming throughout the cms not just in the language strings.

Changes "master" to "main" or "source" as appropriate,

Rationale

https://inclusivenaming.org/word-lists/tier-1/_master/

Test

Code review Only

Documentation

New page will be added to manual.joomla.org shortly

Note

This is part of a series of pull requests that are submitted separately to make reviewing easier

We should be using inclusive naming throughout the cms not just in the language strings.

Changes "master" to "main" or "source" as appropriate,

### Rationale
https://inclusivenaming.org/word-lists/tier-1/_master/

### Test
Code review Only

### Documentation
New page will be added to manual.joomla.org shortly

### Note
This is part of a series of pull requests that are submitted separately to make reviewing easier
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Jun 23, 2023
@alikon
Copy link
Contributor

alikon commented Jun 24, 2023

@brianteeman can you do just 1 pr for this "subject" imho

@alikon
Copy link
Contributor

alikon commented Jun 24, 2023

I have tested this item ✅ successfully on 60cc996


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41020.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 24, 2023

I have tested this item ✅ successfully on 60cc996


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41020.

@Quy
Copy link
Contributor

Quy commented Jun 24, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41020.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 24, 2023
@wilsonge wilsonge enabled auto-merge (squash) June 25, 2023 21:57
@wilsonge wilsonge added this to the Joomla! 4.3.3 milestone Jun 25, 2023
@wilsonge wilsonge merged commit 4be5db7 into joomla:4.3-dev Jun 25, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 25, 2023
@brianteeman brianteeman deleted the inclusive-naming-2 branch June 26, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants