Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Inclusive Naming abort (comments) #41025

Merged
merged 3 commits into from Jun 23, 2023

Conversation

brianteeman
Copy link
Contributor

We should be using inclusive naming throughout the cms not just in the language strings.

Changes "abort" to "stop" or "cancel" as appropriate,

Rationale

https://inclusivenaming.org/word-lists/tier-1/abort/

Test

Code review Only

Documentation

New page will be added to manual.joomla.org shortly

Note

This is part of a series of pull requests that are submitted separately to make reviewing easier

We should be using inclusive naming throughout the cms not just in the language strings.

Changes "abort" to "stop" or "cancel" as appropriate,

### Rationale
https://inclusivenaming.org/word-lists/tier-1/abort/

### Test
Code review Only

### Documentation
New page will be added to manual.joomla.org shortly

### Note
This is part of a series of pull requests that are submitted separately to make reviewing easier
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Jun 23, 2023
@wilsonge wilsonge merged commit 912c352 into joomla:4.3-dev Jun 23, 2023
3 checks passed
@wilsonge
Copy link
Contributor

Merging on review as only code comments. Thanks!

@wilsonge wilsonge added this to the Joomla! 4.3.3 milestone Jun 23, 2023
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the inclusive_naming_5 branch June 23, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants