-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] b/c plugin - Load class aliases earlier and move es5 assets #41202
Conversation
Do you have anything to say @SharkyKZ or would you only like to spread bad vibes? |
@@ -5,5 +5,7 @@ | |||
|
|||
PLG_COMPAT_FIELD_CLASSES_ALIASES_LABEL="Classes Aliases" | |||
PLG_COMPAT_FIELD_CLASSES_ALIASES_DESCRIPTION="Add class aliases for classes which have been renamed or moved to a namespace." | |||
PLG_COMPAT_FIELD_ES5_ASSETS_LABEL="ES5 Assets" | |||
PLG_COMPAT_FIELD_ES5_ASSETS_DESCRIPTION="Load the es5 webasset stubs." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this string be less technical and geeky?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps explaining when/why you might need to enable it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it and I didn't came to a better text, in the end you have to understand what es5 javascript files are... so it's more a template developer setting and not really for end user useful. But I'm happy about a better description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something along the lines of "This should be enabled if you get an error message saying ..."
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
I see that there are still es5 references in |
Thanks, don't know why my initial search didn't found the 3 assets.... in the build folder... the template I didn't checked tbh |
I just grepped for es5 in all joomla.asset.json files |
Does this need changing as well joomla-cms/build/build-modules-js/settings.json Lines 77 to 87 in e7e1fb4
|
I'm not sure I have seen it, @Fedik @dgrammatiko ? |
All what in settings will be in vendor/assets.json |
thanks moved it to the plugin |
Co-authored-by: Brian Teeman <brian@teeman.net>
Hopefully this solve all the JPlugin issues, merging it to get it into alpha3 |
…omla#41202) * Move classmap import to the plugin constructor * Move es5 assets to b/c plugin --------- Co-authored-by: Brian Teeman <brian@teeman.net>
…omla#41202) * Move classmap import to the plugin constructor * Move es5 assets to b/c plugin --------- Co-authored-by: Brian Teeman <brian@teeman.net>
This PR moves the class alias loading to the constructor function of the plugin to load the alias at the earliest possible execution point.
Additional this PR moves all es5 assets from all joomla.asset.json into the es5.asset.json and make loading them optional.
Summary of Changes
Testing Instructions
Full CMS with and without plugin active
Actual result BEFORE applying this Pull Request
Should work
Expected result AFTER applying this Pull Request
Should still work
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed