Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix codemirror height #41432

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[5.0] Fix codemirror height #41432

merged 1 commit into from
Aug 23, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Aug 22, 2023

Pull Request for Issue # .

Summary of Changes

Fix codemirror height

Testing Instructions

Set default editor to codemirror,
Go to Article editing

Actual result BEFORE applying this Pull Request

Editor height 100px

Expected result AFTER applying this Pull Request

Editor height 500px

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added bug Small A PR which only has a small change labels Aug 22, 2023
@Quy
Copy link
Contributor

Quy commented Aug 22, 2023

I have tested this item ✅ successfully on a304b5e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41432.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on a304b5e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41432.

@HLeithner HLeithner merged commit 0c895c3 into joomla:5.0-dev Aug 23, 2023
4 checks passed
@HLeithner
Copy link
Member

thanks

@Fedik Fedik deleted the fix-cm-height branch August 23, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-5.0-dev Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants