Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Smart Search: Allow to hide archived content #41504

Merged
merged 9 commits into from
Sep 2, 2023

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Aug 28, 2023

Pull Request for Issue #41339.

Summary of Changes

The old com_search had an option to search both published and archived content. This PR adds that option to the core Smart Search plugins as well. By default archived content is searched, since that was the behavior until now.

Testing Instructions

  1. Install the testing sampledata
  2. Set an article to archived
  3. Search for that article in smart search
  4. Switch the option in the article finder plugin to no.
  5. Edit the archived article and change something small in it.
  6. Search for the article again
  7. Change the state of the article back to published.
  8. Search for the article again.

Actual result BEFORE applying this Pull Request

The article is always returned as a search result.

Expected result AFTER applying this Pull Request

When at step 6, the article does not show up in the search results anymore.
At step 8, the article does show up again.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Hackwar and others added 2 commits August 31, 2023 06:31
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
@HLeithner
Copy link
Member

Nice feature, allowing to not index any article would be nice too.

@Hackwar
Copy link
Member Author

Hackwar commented Aug 31, 2023

If you don't want to index any articles at all, you can just switch off the content finder plugin. 😉 But I understand that you want an option to not index a content item in the first place. Will see what I can do.

@HLeithner
Copy link
Member

yeah, my wording wasn't specific enough :-(

plugins/finder/tags/tags.xml Outdated Show resolved Hide resolved
@HLeithner
Copy link
Member

documentation is needed here for 3rd party developer and also for users....

@brianteeman
Copy link
Contributor

It's not really a new feature it's more a migration of a long term feature from search to finder

Hackwar and others added 5 commits August 31, 2023 19:25
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
@HLeithner HLeithner merged commit 41d8064 into joomla:5.0-dev Sep 2, 2023
3 checks passed
@HLeithner
Copy link
Member

thanks

@1inkin
Copy link

1inkin commented Jan 26, 2024

Is this feature still planned for inclusion in the Joomla distribution?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41504.

@alikon
Copy link
Contributor

alikon commented Jan 26, 2024

it is already in 5

@1inkin
Copy link

1inkin commented Jan 26, 2024

I found the switch in the plugin settings. Thank you. very useful feature. It would be nice to add a switch to the article parameters to disable indexing of some articles.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41504.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants