Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPDoc in HtmlDocument #41532

Merged
merged 3 commits into from Mar 4, 2024
Merged

Fix PHPDoc in HtmlDocument #41532

merged 3 commits into from Mar 4, 2024

Conversation

Denitz
Copy link
Contributor

@Denitz Denitz commented Aug 31, 2023

Summary of Changes

Change $params from array to Registry, remove useless NULL property defaults.

Testing Instructions

Install patch.

Actual result BEFORE applying this Pull Request

See IDE code inspection issues in Cassiopea's index.php for $this->params->get()

Expected result AFTER applying this Pull Request

$this->params->get() is correctly recognized

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

@laoneo @MacJoom something for you

@HLeithner HLeithner changed the base branch from 4.3-dev to 5.1-dev September 30, 2023 22:49
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@Quy Quy added PR-5.1-dev and removed PR-4.3-dev labels Oct 19, 2023
@bembelimen bembelimen merged commit 006070e into joomla:5.1-dev Mar 4, 2024
3 checks passed
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants