Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing support for "Subcategory Levels" parameter in contacts category view #41618

Merged
merged 11 commits into from Jan 24, 2024

Conversation

artur-stepien
Copy link
Contributor

This adds the support for Subcategory Levels in Category tab of List Contacts in a Category view. Currently, this setting is not applied in the query, so using it will not allow viewing all contacts in the category and its subcategories.

Summary of Changes

Added state entry and query filter for this parameter.

Testing Instructions

  • Create a contact category called All contacts
  • Create a contact category called A and set the parent as All contacts
  • Create a contact category called B and set the parent as All contacts
  • Create contact Contact from A and place it in A category
  • Create contact Contact from B and place it in B category
  • Create a menu item of type List Contacts in a Category, chose category All contacts and make sure in Category tab Subcategory Levels is set to All or any positive value
  • Save and head to the recently created menu item in front-end

Actual result BEFORE applying this Pull Request

There should be no contacts displayed in this view.

Expected result AFTER applying this Pull Request

All contacts from category A and B will be displayed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Add the missing support for `maxLevel` parameter in contacts category view.
@Quy
Copy link
Contributor

Quy commented Sep 7, 2023

Please fix phpcs: https://ci.joomla.org/joomla/joomla-cms/69748/1/8

@artur-stepien
Copy link
Contributor Author

Please fix phpcs: https://ci.joomla.org/joomla/joomla-cms/69748/1/8

Yeah, but what is it complaining about. The lack of alignment between = signs?

@ceford
Copy link
Contributor

ceford commented Sep 25, 2023

I have tested this item ✅ successfully on 696b25d

Without the patch I see just the Subcategories list. With the patch I see the actual contacts in Categories A and B.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618.

@artur-stepien
Copy link
Contributor Author

@Quy Do you know why the test is failing?

@HLeithner HLeithner changed the base branch from 4.3-dev to 5.1-dev September 30, 2023 22:49
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@Quy Quy added PR-5.1-dev and removed PR-4.3-dev labels Oct 19, 2023
@artur-stepien
Copy link
Contributor Author

@HLeithner Do you know why this issue fails build? Its a bug that affects one of clients websites and I see no reply to the question.

@HLeithner
Copy link
Member

I updated the branch, this should retrigger a ci run

Co-authored-by: Quy <quy@nomonkeybiz.com>
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 8ececc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618.

@Quy
Copy link
Contributor

Quy commented Nov 20, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 20, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Jan 18, 2024
@Razzo1987 Razzo1987 merged commit b67dc34 into joomla:5.1-dev Jan 24, 2024
3 checks passed
@Razzo1987
Copy link
Contributor

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants