New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PostgreSQL support for non-standard ports (Issue #4152). #4165
Conversation
Instead of making them local variables, I'd suggest writing the split data back to |
Another solution, now the port was checked in the constructor (and saved in |
I have searched for allowed characters for the hostname (never trust user input) and I've found this: https://tools.ietf.org/html/rfc3986#section-3.2.2 . My solution is not IPv6 compatible. |
Ported your solution for postgresql with two exceptions.
|
Please update your PR to latest staging and fix the merge conflicts. |
Hello @Joe136 Thank you for your contribution. The last comment here was on 3rd February. Can you please respond to the feedback given? Thanks for understanding! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4165. |
Closed due to lack of response for further information - it can always be reopened if that is provided This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4165. |
Here is a pull request as described in my previous issue #4152.
I have tested it with and without port definition and both works in my configuration.