Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PostgreSQL support for non-standard ports (Issue #4152). #4165

Closed
wants to merge 7 commits into from

Conversation

Joe136
Copy link

@Joe136 Joe136 commented Aug 23, 2014

Here is a pull request as described in my previous issue #4152.

I have tested it with and without port definition and both works in my configuration.

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2014

Instead of making them local variables, I'd suggest writing the split data back to $this->options should they need to be reused for anything later (which is the same as what the MySQLi driver does).

@Joe136
Copy link
Author

Joe136 commented Aug 23, 2014

Another solution, now the port was checked in the constructor (and saved in $options / $this->options).
But the isset($options['port']) directive has no effect, it was not passed from configuration.php.

@Joe136
Copy link
Author

Joe136 commented Aug 27, 2014

I have searched for allowed characters for the hostname (never trust user input) and I've found this: https://tools.ietf.org/html/rfc3986#section-3.2.2 . My solution is not IPv6 compatible.

@Joe136
Copy link
Author

Joe136 commented Sep 4, 2014

Ported your solution for postgresql with two exceptions.

  1. different way for unix sockets: I have tested it and it works for me. But it is (currently) limited to special characters: (/[a-zA-Z0-9.-_]*)+ . Additionally something like /var/../var/pg is posible (maybe bad).
  2. IPv6 doesn't need the [] characters. It works for localhost ::1 but not for a real address (eth0 IPv6) (and not with psql; don't know why).

@Hackwar
Copy link
Member

Hackwar commented Feb 3, 2015

Please update your PR to latest staging and fix the merge conflicts.

@roland-d
Copy link
Contributor

roland-d commented Nov 8, 2015

Hello @Joe136

Thank you for your contribution.

The last comment here was on 3rd February. Can you please respond to the feedback given?
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4165.

@brianteeman
Copy link
Contributor

Closed due to lack of response for further information - it can always be reopened if that is provided


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants