Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Add SVG support to mod_banners #41854

Merged
merged 5 commits into from Nov 2, 2023

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Sep 21, 2023

Summary of Changes

It is possible to assign SVG files to banners, however, the module does not reflect it, only allowing image files.

Notes:

An isImage function was created specifically for Banners. However, it should not be necessary to have such a function since the MediaHelper offers it as well. To ensure Banners support the same image file extensions as the rest of the core, I opted for the use of the MediaHelper instead.

SVG files act a bit differently than image files.
When forcing a width and a height on a image, the image will 'follow' those dimensions.
A SVG file will be scaled to fit its defined viewport. So it won't 'obey' a specific height if you set one for the banner.
Depending on your situation, you may have to restrict the SVG's height with max-height.

Use of SVGs in mod_banners is safe, the SVG files are checked in MediaHelper::getMimeType.

Testing Instructions

Create banners in the administration console. Some use standard image files, some use SVG files.

Actual result BEFORE applying this Pull Request

Only banners with standard image files are shown.

Expected result AFTER applying this Pull Request

Banners with standard image files and SVG files are shown.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: link (about the deprecation)

  • No documentation changes for manual.joomla.org needed

Added support for SVG, use of MediaHelper to be consistent throughout.
Deprecate isImage
@ceford
Copy link
Contributor

ceford commented Sep 26, 2023

I have tested this item ✅ successfully on 611d72e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854.

@joomla joomla deleted a comment from ceford Sep 26, 2023
@chmst
Copy link
Contributor

chmst commented Sep 26, 2023

I have tested this item ✅ successfully on 611d72e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854.

@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:48
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@Quy
Copy link
Contributor

Quy commented Oct 5, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 5, 2023
@Quy Quy added the Feature label Oct 5, 2023
@Razzo1987
Copy link
Contributor

I have tested this item ✅ successfully on 9755714

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854.

@Razzo1987 Razzo1987 added this to the Joomla! 5.1.0 milestone Nov 2, 2023
@Razzo1987 Razzo1987 merged commit cbe23b2 into joomla:5.1-dev Nov 2, 2023
3 of 4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants