Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] installation rtl fixes #41877

Conversation

brianteeman
Copy link
Contributor

There are two competing and conflicting declarations for the j-install-step-header span This is the css that puts the space between the icon and the header

Note that the entire RTL css is incorrect but that is for another pr and another time. This PR is only to produce valid css without duplicate classes

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

There are two competing and conflicting declarations for the `j-install-step-header span`
This is the css that puts the space between the icon and the header

Note that the entire RTL css is incorrect but that is for another pr and another time. This PR is only to produce valid css without duplicate classes
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 23, 2023
@HLeithner HLeithner merged commit bbc421e into joomla:5.0-dev Sep 23, 2023
3 checks passed
@brianteeman brianteeman deleted the 13_installation_template_rtl_css_duplication branch September 23, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants