Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Remove duplicate png #41900

Merged
merged 6 commits into from Oct 28, 2023
Merged

[4.4] Remove duplicate png #41900

merged 6 commits into from Oct 28, 2023

Conversation

brianteeman
Copy link
Contributor

simple pr to correct an error from #34634 where png was added twice

Pull Request for Issue #41898 .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

simple pr to correct an error from joomla#34634 where png was added twice
@joomleb
Copy link

joomleb commented Sep 23, 2023

Tested without success
I used the update zip package and I tried also the new installation full zip package

@brianteeman
Copy link
Contributor Author

@joomleb sorry I should have said that this is only for new installs.

@HLeithner HLeithner added the bug label Sep 24, 2023
@sandewt
Copy link
Contributor

sandewt commented Sep 24, 2023

@brianteeman
Copy link
Contributor Author

oops - thanks sql updated as well

@joomleb
Copy link

joomleb commented Sep 24, 2023

@brianteeman
Please, Can you confirm that package has been updated and I can re-test it ?

@brianteeman
Copy link
Contributor Author

yes - the build date/time is on the download page

@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:43
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.4-dev.

@brianteeman brianteeman changed the title [4.3] Remove duplicate png [4.4] Remove duplicate png Sep 30, 2023
@Quy Quy removed the PR-4.3-dev label Oct 1, 2023
@Quy
Copy link
Contributor

Quy commented Oct 10, 2023

I have tested this item ✅ successfully on 1e7a64c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41900.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Oct 10, 2023

I have tested this item ✅ successfully on 1e7a64c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41900.

@alikon
Copy link
Contributor

alikon commented Oct 10, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41900.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 10, 2023
@joomleb
Copy link

joomleb commented Oct 17, 2023

Hi guys,
Why this PR has not been merged into 4.4 ?
Please, What is missing?

@laoneo laoneo merged commit 22984cc into joomla:4.4-dev Oct 28, 2023
3 checks passed
@laoneo
Copy link
Member

laoneo commented Oct 28, 2023

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 28, 2023
@laoneo laoneo added this to the Joomla! 4.4.1 milestone Oct 28, 2023
@brianteeman brianteeman deleted the patch-3 branch October 28, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants