Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Remove unused SCSS #41955

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Sep 27, 2023

Summary of Changes

Removes some as far as I can tell unused SCSS from the login scss. The motivation is that I'm trying to reduce the amount of places we're using var(--template-special-color);

Testing Instructions

Check the login page (including ideally with some passkey & mfa methods enabled. Ideally there should be no differences.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 27, 2023
@ceford
Copy link
Contributor

ceford commented Sep 28, 2023

I have tested this item ✅ successfully on 282800f

I tested with Passkey and Code by email - no obvious differences and it worked fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41955.

@brianteeman
Copy link
Contributor

lgtm

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 282800f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41955.

@Quy
Copy link
Contributor

Quy commented Sep 28, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41955.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 28, 2023
@HLeithner HLeithner merged commit 3454262 into joomla:5.0-dev Sep 30, 2023
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 30, 2023
@wilsonge wilsonge deleted the fix/login-remove-unused-scss branch September 30, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants