Allow to get permitions for section != 'component' #4198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to set ACL different groups based on category permissions, for example:
access.xml
<section name="component">
[...]
</section>
<section name="category">
<action name="roles.list" title="roles list" description="" />
<action name="roles.manage" title="roles manage" description="" />
</section>
view.html.php (view of a generic component)
[...]
$this->canDo = JHelperContent::getActions('com_componentname', 'category', $item->catid);
if (!$this->canDo->get('roles.manage')) {
JError::raiseWarning(404, JText::_('JERROR_ALERTNOAUTHOR'));
$app = JFactory::getApplication();
$app->redirect('index.php');
}
[...]
| @@ -116,7 +116,12 @@ public static function getActions($component = '', $section = '', $id = 0) | |||
| $assetName = $component; | |||
| } | |||
|
|
|||
| $actions = JAccess::getActionsFromFile($path, "/access/section[@name='component']/"); | |||
| if(empty($section)) | |||
There was a problem hiding this comment.
please add a space here:
if (empty($section))
|
@test successful good catch. |
|
I did the changes you suggested. |
on line 123: https://github.com/joomla/joomla-cms/pull/4198/files#diff-70a9f5171aac5ecc71b5c63f03bdfee1R123 do you add two tabs that should be removed :D |
|
Done. Thank you. |
|
thanks @berlanda so we need on more test here 👍 |
Bakual
pushed a commit
to Bakual/joomla-cms
that referenced
this pull request
Sep 24, 2014
Reverting PR joomla#4198 since it broke "Save to Copy" and "Save & New" buttons in com_content.
piotr-cz
pushed a commit
to piotr-cz/joomla-cms
that referenced
this pull request
Oct 6, 2014
…a#4198 This will allow to set ACL different groups based on category permissions, for example: access.xml <section name="component"> [...] </section> <section name="category"> <action name="roles.list" title="roles list" description="" /> <action name="roles.manage" title="roles manage" description="" /> </section> view.html.php (view of a generic component) [...] $this->canDo = JHelperContent::getActions('com_componentname', 'category', $item->catid); if (!$this->canDo->get('roles.manage')) { JError::raiseWarning(404, JText::_('JERROR_ALERTNOAUTHOR')); $app = JFactory::getApplication(); $app->redirect('index.php'); } [...] Update content.php Update content.php
piotr-cz
pushed a commit
to piotr-cz/joomla-cms
that referenced
this pull request
Oct 6, 2014
Reverting PR joomla#4198 since it broke "Save to Copy" and "Save & New" buttons in com_content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to set ACL different groups based on category permissions, for example:
access.xml
<section name="component">
[...]
</section>
<section name="category">
<action name="roles.list" title="roles list" description="" />
<action name="roles.manage" title="roles manage" description="" />
</section>
view.html.php (view of a generic component)
[...]
$this->canDo = JHelperContent::getActions('com_componentname', 'category', $item->catid);
if (!$this->canDo->get('roles.manage')) {
JError::raiseWarning(404, JText::_('JERROR_ALERTNOAUTHOR'));
$app = JFactory::getApplication();
$app->redirect('index.php');
}
[...]