Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Remove unused SCSS from cpanel file #41993

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

wilsonge
Copy link
Contributor

Summary of Changes

This removes some as far as I can tell unused SCSS from the cpanel module. I cannot find any references to .cpanel-add-module-icon-help, .com-cpanel-help, .cpanel-add-module-icon-system or .com-cpanel-system inside core.

Additionally when viewing the help page in the main menu or any of the cpanel dashboards I can't see any visually differences changes after applying this

Testing Instructions

Validate classes don't exist in core and all cpanel views (primary dashboard, system dashboard and help page) are unchanged after applying this PR

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 29, 2023
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 0f28b1b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41993.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Sep 29, 2023

I have tested this item ✅ successfully on 0f28b1b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41993.

@Quy
Copy link
Contributor

Quy commented Sep 29, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41993.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 29, 2023
@HLeithner HLeithner merged commit ec5a9f8 into joomla:5.0-dev Sep 30, 2023
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 30, 2023
@wilsonge wilsonge deleted the fix/remove-unused-cpanel-scss branch September 30, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants