[5.0] Fix permissions list color in dark mode #42006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
wilsonge
changed the title
wilsonge
force-pushed
the
fix/permissions-color-dark-mode
branch
from
9df47be
to
3cc6153
Compare
wilsonge
force-pushed
the
fix/permissions-color-dark-mode
branch
from
3cc6153
to
3699b78
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41778 (partial).
Summary of Changes
Removes the color override of specific buttons in joomla tabs. I think this is only used in core with permissions but there might be other 3rd party uses?
Testing Instructions
Check the permissions tab in dark and light mode. The color change in light mode is to my eyes at least barely noticeable. But there's a clear improvement in dark mode. If people think the light mode color change is more noticable I can make further fixes.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed