Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog for Shortcut overview #42081

Merged
merged 3 commits into from Dec 16, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Oct 7, 2023

Summary of Changes

Use Dialog for Shortcut overview, instead of BS modal.

Testing Instructions

Run npm install
Check shortcut overview works as before (j + x shortcut).

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Oct 7, 2023
@Fedik Fedik added the Feature label Oct 7, 2023
 Conflicts:
	build/media_source/plg_system_shortcut/js/shortcut.es6.js
@JonasAtZwetschke
Copy link

I have tested this item ✅ successfully on 7ff0791


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42081.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 7ff0791


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42081.

@Quy
Copy link
Contributor

Quy commented Nov 14, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42081.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 14, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Nov 15, 2023
@LadySolveig LadySolveig merged commit 481a5d6 into joomla:5.1-dev Dec 16, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 16, 2023
@LadySolveig
Copy link
Contributor

Thank you for your work @Fedik !
I am also very happy about the eager testers and the review - thank you @JonasAtZwetschke @viocassel and @dgrammatiko

@Fedik Fedik deleted the dialog-for-shortcut-plg branch December 16, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants