Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] webservices plugins use concrete event classes #42092

Merged
merged 9 commits into from Mar 4, 2024

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Oct 8, 2023

Summary of Changes

use concrete event classes for webservices plugins introduced with #40522

Testing Instructions

test API endpoints
(many plugins/endpoints are also tested by system tests)

Actual result BEFORE applying this Pull Request

webservices plugins use legacy listeners

Expected result AFTER applying this Pull Request

webservices plugins use SubscriberInterface and concrete events (actual coding standard)

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@heelc29 heelc29 marked this pull request as ready for review October 8, 2023 19:24
@Fedik Fedik added the Feature label Oct 9, 2023
@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 96c46e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42092.

@LadySolveig LadySolveig merged commit a2f352c into joomla:5.1-dev Mar 4, 2024
2 of 3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @heelc29

@heelc29 heelc29 deleted the 5.1/plugins/webservices/events branch March 4, 2024 15:24
@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants