Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making error message user-friendly (suggesting fix) and increasing recommended maximum upload size to 8 MB #4210

Closed
wants to merge 3 commits into from

Conversation

beat
Copy link
Contributor

@beat beat commented Sep 3, 2014

Executive summary

  1. Error message for maximum upload size is not hinting exact origin of problem nor how to fix the issue.
  2. Recommended maximum upload size is 4 MB, which is smaller than most major components.
  3. Error messages for upload size and post size wrongly indicate 2 MB instead of 4 MB now and are fixed to 8 MB with this PR too.

This PR is independent of #4209 , but is a useful addition.

Backwards compatibility

No backwards compatibility issues are introduced.

Translation impact

No translation strings are added or deleted, but 2 strings are updated to be more precise.

Testing instructions

Apply #4209

Test 1: Make sure that your server's php.ini has a max_upload_size of 1M. Try installing an extension bigger than that, e.g. Admin Tools Core, K2, Community Builder etc. You get a generic upload error. Apply the PR and retry. You now get an error telling you that the upload failed and that your maximum upload limit is too small.

Test 2: Go to Extensions / Extensions Manager and click Warnings on side-bar. You should see the updated message and limit too.

@infograf768
Copy link
Member

Agree with this.
@test OK

@brianteeman
Copy link
Contributor

interesting that the error message previously said <2mb when the code was checking for 4mb

@phproberto phproberto closed this in 4aa423c Sep 3, 2014
@phproberto
Copy link
Contributor

Merged. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants