[4.4] Update tag router to restrict lossy matches to menu items set to any #42162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40750 .
Summary of Changes
Only populate the menu items into $this->lookup if they are a direct match, or return_any_or_all is set to any.
Testing Instructions
Setup two tags.
Setup a menu item point to a singular tag
Setup a second menu item pointing to both tags, match type All
Populate articles into the first tag to show pagination within page (can change global config list limit to 5 to make this easier)
Navigate to the first menu item on the front end.
Observe pagination links
Actual result BEFORE applying this Pull Request
Pagination URL incorrectly pointing to second menu item (with multiple tags selected), instead of the current menu item.
Page: /tag-1 pagination link: /tag-1-and-2?start=5
Example: Page: /tag-1 pagination link: /tag-1?start=5
Expected result AFTER applying this Pull Request
Pagination URL's now correctly paginate through the current menu item.
Example: Page: /tag-1 pagination link: /tag-1-and-2?start=5
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed