Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Update tag router to restrict lossy matches to menu items set to any #42162

Open
wants to merge 1 commit into
base: 4.4-dev
Choose a base branch
from

Conversation

shane-clickingmad
Copy link

Pull Request for Issue #40750 .

Summary of Changes

Only populate the menu items into $this->lookup if they are a direct match, or return_any_or_all is set to any.

Testing Instructions

Setup two tags.
Setup a menu item point to a singular tag
Setup a second menu item pointing to both tags, match type All
Populate articles into the first tag to show pagination within page (can change global config list limit to 5 to make this easier)
Navigate to the first menu item on the front end.
Observe pagination links

Actual result BEFORE applying this Pull Request

Pagination URL incorrectly pointing to second menu item (with multiple tags selected), instead of the current menu item.
Page: /tag-1 pagination link: /tag-1-and-2?start=5

Example: Page: /tag-1 pagination link: /tag-1?start=5

Expected result AFTER applying this Pull Request

Pagination URL's now correctly paginate through the current menu item.

Example: Page: /tag-1 pagination link: /tag-1-and-2?start=5

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Hackwar Hackwar self-assigned this Oct 25, 2023
@Fedik Fedik added the bug label Nov 10, 2023
@exlemor
Copy link

exlemor commented Apr 21, 2024

Hi @shane-clickingmad, I tried to follow your testing instructions step by step but I think something is missing as it did not yield what was supposed to be happen ;-(

Can you please check them so that I can test it again very soon.

(sorry)

@HLeithner HLeithner changed the title Update tag router to restrict lossy matches to menu items set to any [4.4] Update tag router to restrict lossy matches to menu items set to any Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants