Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] User field: fix "No user" selection #42256

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Oct 31, 2023

Pull Request for Issue #42255 .

Summary of Changes

User field: fix button "No user"

Testing Instructions

Edit any Contact,
Asign User,
Then open User selection dialog again and click "- No User -"

Actual result BEFORE applying this Pull Request

Nothing happened

Expected result AFTER applying this Pull Request

Dialog is closed and User is unselected

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

@HLeithner
Copy link
Member

@fgsw can you please test this PR

@Fedik Fedik added the Small A PR which only has a small change label Oct 31, 2023
@fgsw
Copy link

fgsw commented Oct 31, 2023

I have tested this item ✅ successfully on 0f16063


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42256.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Oct 31, 2023

I have tested this item ✅ successfully on 0f16063


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42256.

@Quy Quy removed bug Small A PR which only has a small change labels Oct 31, 2023
@Quy
Copy link
Contributor

Quy commented Oct 31, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42256.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 31, 2023
@HLeithner HLeithner merged commit 9e13dd7 into joomla:5.0-dev Oct 31, 2023
2 of 3 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 31, 2023
@Quy Quy added this to the Joomla! 5.0.1 milestone Oct 31, 2023
@Fedik Fedik deleted the fix42255 branch October 31, 2023 13:43
@dautrich
Copy link

I have tested this item ✅ successfully on 0f16063


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants