New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Use Dialog field for Modal_Category #42293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Fedik
changed the title
[5.1] Modal field for Modal_Category
[5.1] Use Dialog field for Modal_Category
Nov 5, 2023
Fedik
force-pushed
the
popup-field-category
branch
from
November 6, 2023 11:40
77bc685
to
d6f9b22
Compare
joomla-cms-bot
added
Language Change
This is for Translators
NPM Resource Changed
This Pull Request can't be tested by Patchtester
Unit/System Tests
labels
Nov 6, 2023
Fedik
added
PR-5.1-dev
and removed
Unit/System Tests
PR-5.0-dev
Language Change
This is for Translators
labels
Nov 6, 2023
joomla-cms-bot
removed
the
NPM Resource Changed
This Pull Request can't be tested by Patchtester
label
Nov 6, 2023
I have tested this item ✅ successfully on 88cb998 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293. |
I have tested this item ✅ successfully on 88cb998 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293. |
Thank you @Fedik ! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changing
Modal_Category
field to use new modal dialog.The same as #40462 but for Category.
Testing Instructions
Create a menu for category,
Select/edit value in "Choose a Category" field
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Reference: