Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog field for Modal_Category #42293

Merged
merged 11 commits into from Nov 14, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 5, 2023

Summary of Changes

Changing Modal_Category field to use new modal dialog.
The same as #40462 but for Category.

Testing Instructions

Create a menu for category,
Select/edit value in "Choose a Category" field

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: Content select in modal Manual#178
  • No documentation changes for manual.joomla.org needed

Reference:

@Fedik Fedik added the Feature label Nov 5, 2023
@Fedik Fedik changed the base branch from 5.0-dev to 5.1-dev November 5, 2023 10:30
@Fedik Fedik changed the base branch from 5.1-dev to 5.0-dev November 5, 2023 10:30
@Fedik

This comment was marked as outdated.

@Fedik Fedik changed the title [5.1] Modal field for Modal_Category [5.1] Use Dialog field for Modal_Category Nov 5, 2023
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester Unit/System Tests labels Nov 6, 2023
@Fedik Fedik changed the base branch from 5.0-dev to 5.1-dev November 6, 2023 11:40
@joomla-cms-bot joomla-cms-bot removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Nov 6, 2023
@Quy
Copy link
Contributor

Quy commented Nov 7, 2023

I have tested this item ✅ successfully on 88cb998


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 88cb998


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293.

@Quy
Copy link
Contributor

Quy commented Nov 10, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42293.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 10, 2023
@LadySolveig LadySolveig merged commit 4a7718a into joomla:5.1-dev Nov 14, 2023
3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @Fedik !
And thanks to the diligent testers @viocassel @Quy

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2023
@Fedik Fedik deleted the popup-field-category branch November 14, 2023 09:44
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants