Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Cassiopeia should respect inheritance #42294

Merged
merged 2 commits into from Nov 6, 2023

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #42260 .

Summary of Changes

  • The code for the Colour Theme should respect inheritance and allow overrides, right now it's hardcoded to the parent template

Testing Instructions

  • Apply the patch
  • Check that the Colour Theme value is respected
  • Create a child template test
  • Create a file media/templates/site/cassiopeia_test/css/global/colors_standard.css and a file media/templates/site/cassiopeia_test/css/global/colors_standard.min.css with contents:
:root {
  --cassiopeia-color-primary: rebeccapurple;
  --cassiopeia-color-link: rebeccapurple;
  --link-color: rebeccapurple;
  --link-color-rgb: 34, 79, 170;
  --cassiopeia-color-hover: rebeccapurple;
}

Check that when the field Colour Theme has a value standard the template has a purple colour for the links and header

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@astridx

Signed-off-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@Fedik Fedik added the bug label Nov 5, 2023
Signed-off-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@Fedik
Copy link
Member

Fedik commented Nov 5, 2023

I have tested this item ✅ successfully on 5234af2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42294.

@astridx
Copy link
Contributor

astridx commented Nov 5, 2023

I have tested this item ✅ successfully on 5234af2

Thank you very much @dgammatiko


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42294.

@alikon
Copy link
Contributor

alikon commented Nov 5, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42294.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 5, 2023
@HLeithner HLeithner merged commit d2f6dd7 into joomla:5.0-dev Nov 6, 2023
4 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 6, 2023
@dgrammatiko dgrammatiko deleted the 5.0-dev-cassiopeia-child branch November 6, 2023 09:47
@Quy Quy added this to the Joomla! 5.0.1 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants